-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add copy button to some dropdown accounts #7689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally:
- DeFi ✅
https://jam.dev/c/8b98c3aa-8a6e-4cc5-a684-120ba8d46b46
- Send input ✅
https://jam.dev/c/a34bf5b7-d7cb-4135-bfc0-45d160b1186f
- RFOX 🚫
Multi-account RUNE address isn't copied, the 0th account_index is instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested locally, confirmed RFOX is now happy:
- RUNE Addy
https://jam.dev/c/ce329792-051d-4148-a80a-eabccf4fe242
- FOX.ETH / FOX.ARB addy:
Description
There are a few places where we want to add the copy button to the dropdown accounts components:
I also removed the account auto selection based on the highest amount account, because it was causing a bug inside
AccountDropdown
where this component didn't know the accountId changed, it was used as default value but not as a reactive valueAs this logic is buggy and almost everyone agrees that we should ditch it, I removed it and the bug naturally disappeared
Follow up of #7663 as AccountDropdown was a specific case
Issue (if applicable)
closes #7624
Risk
Low
Testing
AccountDropdown
components should be kopiableEngineering
n/a
Operations
n/a
Screenshots (if applicable)