Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch assets prorate sell amount over previous sell amount USD value #8394

Merged
merged 8 commits into from
Dec 30, 2024

Conversation

gomesalexandre
Copy link
Contributor

Description

Does what it says on the box: allows for switch assets to yield the same fiat value as previously input.
Note, this may not necessarily correspond to the buy value in fiat terms, since the buy value is after fees and the output may be very different depending on swappers.

Issue (if applicable)

closes #8376

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low, isolated to assets switch

Testing

Test in both limit and spot:

  • Input some sell amount for a given pair
  • Switch assets
  • Notice that the sell amount for the sell asset (i.e the previous buy asset) is the same in USD terms

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/5a86cf7d-0327-4065-97cd-4dd97f946039

@gomesalexandre gomesalexandre requested a review from a team as a code owner December 17, 2024 20:18
Base automatically changed from feat_rm_walletsupport_limitations_switchAssets to develop December 18, 2024 14:55
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeOMakinG NeOMakinG enabled auto-merge (squash) December 30, 2024 10:18
@NeOMakinG NeOMakinG merged commit 36b9998 into develop Dec 30, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the feat_switch_assets_prorate_market_data branch December 30, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants