Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit display delta between price and market #8412

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: limit display delta between price and market #8412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83d0bf
feat: limit display delta between price and market
gomesalexandre Dec 19, 2024
e66758e
Merge branch 'develop' into fix_limit_display_delta
gomesalexandre Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
MenuOptionGroup,
Skeleton,
Stack,
Text as CText,
} from '@chakra-ui/react'
import type { Asset } from '@shapeshiftoss/types'
import { bnOrZero } from '@shapeshiftoss/utils'
Expand All @@ -21,6 +22,7 @@ import { SwapIcon } from 'components/Icons/SwapIcon'
import { Text } from 'components/Text'
import { useActions } from 'hooks/useActions'
import { useLocaleFormatter } from 'hooks/useLocaleFormatter/useLocaleFormatter'
import { bn } from 'lib/bignumber/bignumber'
import { assertUnreachable } from 'lib/utils'
import {
ExpiryOption,
Expand All @@ -30,6 +32,7 @@ import {
import { limitOrderInput } from 'state/slices/limitOrderInputSlice/limitOrderInputSlice'
import {
selectExpiry,
selectLimitPrice,
selectLimitPriceDirection,
selectLimitPriceForSelectedPriceDirection,
selectLimitPriceMode,
Expand Down Expand Up @@ -90,6 +93,7 @@ export const LimitOrderConfig = ({
const limitPriceForSelectedPriceDirection = useAppSelector(
selectLimitPriceForSelectedPriceDirection,
)
const limitPrice = useAppSelector(selectLimitPrice)
const priceDirection = useAppSelector(selectLimitPriceDirection)
const expiry = useAppSelector(selectExpiry)
const limitPriceMode = useAppSelector(selectLimitPriceMode)
Expand Down Expand Up @@ -194,10 +198,29 @@ export const LimitOrderConfig = ({
[setExpiry],
)

const renderDelta = useMemo(() => {
const delta = bn(limitPrice.buyAssetDenomination).div(marketPriceBuyAsset).minus(1).times(100)
const prefix = delta.gt(0) ? '+' : ''
NeOMakinG marked this conversation as resolved.
Show resolved Hide resolved

if (limitPrice.buyAssetDenomination === '') return null
if (isLoading) return null
if (delta.isZero()) return null

return (
<CText color={delta.gt(0) ? 'text.success' : 'text.error'}>
({prefix}
{delta.toFixed(2)}%)
</CText>
)
}, [isLoading, limitPrice.buyAssetDenomination, marketPriceBuyAsset])

return (
<Stack spacing={4} px={6} py={4}>
<Flex justifyContent='space-between' alignItems='center'>
<Text translation='limitOrder.whenPriceReaches' />
<HStack>
<Text translation='limitOrder.whenPriceReaches' />
{renderDelta}
</HStack>
<Flex justifyContent='space-between' alignItems='center'>
<Text translation='limitOrder.expiry' mr={4} />
<Menu isLazy>
Expand Down