fix: lifi final quote failures #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles rare, but existing edge-case of Li.Fi erroring at final quote
/routescall.Issue (if applicable)
closes #8386
Risk
Low to none
Testing
Ensure you're not rate-limited already (fresh vpn server)
Get and select Li.Fi rate
Block li.quest request domain before getting final quote (see Jam)
Notice blank screen bork does not ensue
Remove domain blocking before clicking sign and broadcast
Notice Tx goes through (assuming you're not rate-limited)
Repeat steps above while keeping the block, and notice Tx fails (expected, because
/stepTransactionfails, but without blank screen)Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/61f80ed5-41c5-427c-80d7-e7daab97546f