Page: rename contentType as openGraphType

sharetribe · Feb 7, 2023 · bdce95d · bdce95d
1 parent 162bed8
commit bdce95d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/src/components/Page/Page.js b/src/components/Page/Page.js
@@ -78,7 +78,7 @@ class PageComponent extends Component {
       scrollingDisabled,
       referrer,
       author,
-      contentType,
+      openGraphType,
       description,
       facebookImages,
       published,
@@ -126,8 +126,8 @@ class PageComponent extends Component {
 
     const metaToHead = metaTagProps({
       author,
-      contentType,
       description: metaDescription,
+      openGraphType,
       facebookImages: facebookImgs,
       twitterImages: twitterImgs,
       published,
@@ -231,7 +231,7 @@ PageComponent.defaultProps = {
   rootClassName: null,
   children: null,
   author: null,
-  contentType: 'website',
+  openGraphType: 'website',
   description: null,
   facebookImages: null,
   twitterImages: null,
@@ -254,7 +254,7 @@ PageComponent.propTypes = {
 
   // SEO related props
   author: string,
-  contentType: string, // og:type
+  openGraphType: string, // og:type
   description: string, // page description
   facebookImages: arrayOf(
     shape({

diff --git a/src/containers/ListingPage/ListingPage.js b/src/containers/ListingPage/ListingPage.js
@@ -391,7 +391,6 @@ export class ListingPageComponent extends Component {
         title={schemaTitle}
         scrollingDisabled={scrollingDisabled}
         author={authorDisplayName}
-        contentType="website"
         description={description}
         facebookImages={facebookImages}
         twitterImages={twitterImages}

diff --git a/src/containers/ListingPage/__snapshots__/ListingPage.test.js.snap b/src/containers/ListingPage/__snapshots__/ListingPage.test.js.snap
@@ -3,7 +3,6 @@
 exports[`ListingPage matches snapshot 1`] = `
 <Page
   author="user-1 display name"
-  contentType="website"
   description="listing1 description"
   facebookImages={Array []}
   schema={

diff --git a/src/util/seo.js b/src/util/seo.js
@@ -15,8 +15,8 @@ const ensureOpenGraphLocale = locale => {
 export const openGraphMetaProps = data => {
   const {
     canonicalRootURL,
-    contentType,
     description,
+    openGraphType,
     facebookAppId,
     facebookImages,
     locale,
@@ -28,12 +28,12 @@ export const openGraphMetaProps = data => {
     url,
   } = data;
 
-  if (!(title && description && contentType && url && facebookImages && canonicalRootURL)) {
+  if (!(title && description && openGraphType && url && facebookImages && canonicalRootURL)) {
     /* eslint-disable no-console */
     if (console && console.warn) {
       console.warn(
         `Can't create Open Graph meta tags:
-        title, description, contentType, url, facebookImages, and canonicalRootURL are needed.`
+        title, description, openGraphType, url, facebookImages, and canonicalRootURL are needed.`
       );
     }
     /* eslint-enable no-console */
@@ -43,7 +43,7 @@ export const openGraphMetaProps = data => {
   const openGraphMeta = [
     { property: 'og:description', content: description },
     { property: 'og:title', content: title },
-    { property: 'og:type', content: contentType },
+    { property: 'og:type', content: openGraphType },
     { property: 'og:url', content: url },
     { property: 'og:locale', content: ensureOpenGraphLocale(locale) },
   ];