Skip to content

Commit

Permalink
Merge pull request #1255 from sharetribe/fix-final-form-props
Browse files Browse the repository at this point in the history
Don't pass invalid prop to Final Form
  • Loading branch information
Gnito authored Feb 3, 2020
2 parents 5d55d69 + ab252f8 commit bfe98da
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ way to update this template, but currently, we follow a pattern:

---

## Upcoming version 2019-XX-XX
## Upcoming version 2020-XX-XX

## [v4.1.0] 2020-02-03

- [fix] Remove unused 'invalid' prop that breaks some versions of Final Form
[#1255](https://github.com/sharetribe/ftw-daily/pull/1255)
- [fix] Fix `console.warn` functions. [#1252](https://github.com/sharetribe/ftw-daily/pull/1252)
- [fix] Add missing countries (e.g. MX and JP) to `StripeBankAccountTokenInput` validations.
- [add] Add missing countries (e.g. MX and JP) to `StripeBankAccountTokenInput` validations.
[#1250](https://github.com/sharetribe/ftw-daily/pull/1250)

## [v4.0.0] 2019-12-19
Expand Down
4 changes: 1 addition & 3 deletions src/forms/PaymentMethodsForm/PaymentMethodsForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* It's also handled separately in handleSubmit function.
*/
import React, { Component } from 'react';
import { bool, func, object, string } from 'prop-types';
import { func, object, string } from 'prop-types';
import { FormattedMessage, injectIntl, intlShape } from '../../util/reactIntl';
import { Form as FinalForm } from 'react-final-form';
import classNames from 'classnames';
Expand Down Expand Up @@ -284,7 +284,6 @@ PaymentMethodsForm.defaultProps = {
rootClassName: null,
inProgress: false,
handleSubmit: null,
invalid: false,
addPaymentMethodError: null,
deletePaymentMethodError: null,
createStripeCustomerError: null,
Expand All @@ -295,7 +294,6 @@ PaymentMethodsForm.defaultProps = {
PaymentMethodsForm.propTypes = {
formId: string,
intl: intlShape.isRequired,
invalid: bool,
handleSubmit: func,
addPaymentMethodError: object,
deletePaymentMethodError: object,
Expand Down

0 comments on commit bfe98da

Please sign in to comment.