-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update actions to run on Node 16 #1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I think we lose from using the actions-rs actions is caching between different builds. I don't know how much of a difference that would make for this.
actions-rs is currently inactive and has an issue like actions-rs/cargo#216
actions-rs is currently inactive and has an issue like actions-rs/toolchain#219
7f7d082
to
f52eaa9
Compare
Check latest CI tests here. (https://github.com/miles170/fd/actions/runs/3376050377) |
I checked the code and it never uses actions-rs/toolchain rustc_hash before. |
You could use https://github.com/Swatinem/rust-cache for caching |
@tmccombs Would you like to let me try |
I'm fine with either. |
We must place |
e3be83a
to
aeccdc6
Compare
aeccdc6
to
b389f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Just a minor question
Check latest CI tests here. (https://github.com/miles170/fd/actions/runs/3457767586) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Partial fix for #1156.
All tests are passed, as you can see here. (https://github.com/miles170/fd/actions/runs/3457767586)