-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add years and months to the human date formatter #425
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8d9b6e6
Add years and months to human date formatter
ValentinLeTallec 13591eb
Fix error on modules_are_self_consistent
ValentinLeTallec ec0f441
Manage negative times
ValentinLeTallec 0e2c58e
Change human format to "1156 days + 14 hours + ... (approx. 3 years +…
ValentinLeTallec e1a7f80
Merge branch 'pr/425_human_format'
ValentinLeTallec 78d94cc
Impact test with new format
ValentinLeTallec b09e7ba
Reduce clutter in human time
ValentinLeTallec 273f913
Merge branch 'pr/425_human_format'
ValentinLeTallec bbe7d19
Use variable in funtion to simplify
ValentinLeTallec a6c2f0f
Use variable in funtion to simplify
ValentinLeTallec 89a141b
fix floating point precision problem
ValentinLeTallec ac53ad5
Merge remote-tracking branch 'origin/master' into ValentinLeTallec/ma…
sharkdp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,58 @@ | ||
use core::functions | ||
use core::strings | ||
use units::si | ||
use units::time | ||
use datetime::functions | ||
|
||
fn _human_num_days(time: Time) -> Scalar = floor(time / days) | ||
|
||
fn _human_join(a: String, b: String) -> String = | ||
if str_slice(a, 0, 2) == "0 " then b else if str_slice(b, 0, 2) == "0 " then a else "{a} + {b}" | ||
|
||
fn _remove_plural_suffix(str: String) -> String = | ||
if str_slice(str, 0, 2) == "1 " then str_slice(str, 0, str_length(str) - 1) else str | ||
|
||
fn _human_seconds(dt: DateTime) -> String = | ||
_remove_plural_suffix(format_datetime("%-S%.f seconds", dt)) | ||
|
||
fn _human_minutes(dt: DateTime) -> String = | ||
_remove_plural_suffix(format_datetime("%-M minutes", dt)) | ||
|
||
fn _human_hours(dt: DateTime) -> String = | ||
_remove_plural_suffix(format_datetime("%-H hours", dt)) | ||
|
||
fn _human_days(num_days: Scalar) -> String = | ||
_remove_plural_suffix("{num_days} days") | ||
|
||
fn _human_readable_duration(time: Time, dt: DateTime, num_days: Scalar) -> String = | ||
_human_join(_human_join(_human_join(_human_days(_human_num_days(time)), _human_hours(dt)), _human_minutes(dt)), _human_seconds(dt)) | ||
if a == "" then b else if b == "" then a else "{a} + {b}" | ||
|
||
fn _prettier(str: String) -> String = | ||
if str_slice(clean_str, 0, 2) == "0 " then "" | ||
else if str_slice(clean_str, 0, 2) == "1 " then str_slice(clean_str, 0, str_length(clean_str) - 1) | ||
else clean_str | ||
where clean_str = str_replace(str, ".0 ", " ") | ||
|
||
fn _human_years(time: Time) -> String = "{(time -> years) / year |> floor} years" -> _prettier | ||
fn _human_months(time: Time) -> String = "{(time -> months) / month |> round} months" -> _prettier | ||
|
||
fn _human_days(time: Time) -> String = "{(time -> days) / day |> floor} days" -> _prettier | ||
fn _human_hours(time: Time) -> String = "{(time -> hours) / hour |> floor} hours" -> _prettier | ||
fn _human_minutes(time: Time) -> String = "{(time -> minutes) / minute |> floor} minutes" -> _prettier | ||
|
||
fn _precise_human_months(time: Time) -> String = "{(time -> months) / month } months" -> _prettier | ||
fn _precise_human_days(time: Time) -> String = "{(time -> days) / day } days" -> _prettier | ||
fn _precise_human_seconds(time: Time) -> String = "{(time -> seconds) / second} seconds" -> _prettier | ||
|
||
fn _human_recurse(t: Time, result: String, time_unit: String) -> String = | ||
if time_unit == "day" | ||
then _human_recurse(t - (t |> floor_in(day)), _human_join(result, t -> _human_days), "hour") | ||
else if time_unit == "hour" | ||
then _human_recurse(t - (t |> floor_in(hour)), _human_join(result, t -> _human_hours), "minute") | ||
else if time_unit == "minute" | ||
then _human_recurse(t - (t |> floor_in(min)), _human_join(result, t -> _human_minutes), "second") | ||
else _human_join(result, (t |> round_in(ms)) -> _precise_human_seconds) | ||
|
||
fn _year_month_approx(t: Time) -> String = _human_join(the_years -> _human_years, t - the_years -> _human_months) | ||
where the_years = t |> floor_in(year) | ||
|
||
fn _human_manage_past(str: String, time: Time) = str_append(str, if time < 0 s then " ago" else "") | ||
|
||
fn _human_for_long_duration(human_days: String, human_years: String) -> String = | ||
"{human_days} (approx. {human_years})" | ||
|
||
fn _abs_human(time: Time) -> String = | ||
if time == 0 s then "0 seconds" | ||
else if time < 60 seconds then time -> _precise_human_seconds | ||
else if time < 2 months then _human_recurse(time, "", "day") | ||
else if time < 1 year | ||
then _human_for_long_duration(time -> _precise_human_days, (time |> round_in(month/10)) -> _precise_human_months) | ||
else if time < 100 years | ||
then _human_for_long_duration(time -> _precise_human_days, _year_month_approx(time)) | ||
else | ||
_human_for_long_duration(time -> _precise_human_days, time -> _human_years) | ||
|
||
# Implementation details: | ||
# we skip hours/minutes/seconds for durations larger than 1000 days because: | ||
# (a) we run into floating point precision problems at the nanosecond level at this point | ||
# (b) for much larger numbers, we can't convert to DateTimes anymore | ||
@name("Human-readable time duration") | ||
@url("https://numbat.dev/doc/date-and-time.html") | ||
@description("Converts a time duration to a human-readable string in days, hours, minutes and seconds.") | ||
fn human(time: Time) = | ||
if _human_num_days(time) > 1000 | ||
then "{_human_num_days(time)} days" | ||
else _human_readable_duration(time, datetime("0001-01-01T00:00:00Z") + time, _human_num_days(time)) | ||
fn human(time: Time) -> String = _human_manage_past(abs(time) -> _abs_human, time) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test missing now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of #589 😅 , but with your answer there, I think I could improve the code here to have it work too 🙂 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed in 89a141b