Add (unit) list utillity functions #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
reviewed
Oct 23, 2024
sharkdp
requested changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found I needed some more functions to work with lists and unit_lists's for my human implementation to be more reliable. This PR contains those added functions as I feel like those changes are important on their own.
I've added the following utility functions:
I also changed the implementation of unit_list slightly to ignore the order of units in the list (always sorted in largest to smallest unit) and to remove duplicates. I was uncertain if this was desirable, but as no other configuration of units make sense for unit_list, I feel like this is a reasonable change.