Use boolean pipe

shashankbrgowda · Oct 8, 2024 · de035bd · de035bd
1 parent 6e63137
commit de035bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/apollo-collaboration-server/src/features/features.controller.ts b/packages/apollo-collaboration-server/src/features/features.controller.ts
@@ -1,4 +1,11 @@
-import { Controller, Get, Logger, Param, Query } from '@nestjs/common'
+import {
+  Controller,
+  Get,
+  Logger,
+  Param,
+  ParseBoolPipe,
+  Query,
+} from '@nestjs/common'
 
 import { FeatureRangeSearchDto } from '../entity/gff3Object.dto'
 import { Role } from '../utils/role/role.enum'
@@ -56,10 +63,11 @@ export class FeaturesController {
   @Get(':featureid')
   getFeature(
     @Param('featureid') featureid: string,
-    @Query('topLevel') topLevel: string,
+    @Query('topLevel', new ParseBoolPipe({ optional: true }))
+    topLevel: boolean | undefined,
   ) {
     this.logger.debug(`Get feature by featureId: ${featureid}`)
-    return this.featuresService.findById(featureid, topLevel == 'true')
+    return this.featuresService.findById(featureid, topLevel)
   }
 
   @Get('check/:featureid')

diff --git a/packages/apollo-collaboration-server/src/features/features.service.ts b/packages/apollo-collaboration-server/src/features/features.service.ts
@@ -75,7 +75,7 @@ export class FeaturesService {
    * @param topLevel - If true, return the top level feature and its children. If false, return the requested feature and its children.
    * @returns Return the feature(s) if search was successful. Otherwise throw exception
    */
-  async findById(featureId: string, topLevel: boolean) {
+  async findById(featureId: string, topLevel?: boolean) {
     // Search correct feature
     const topLevelFeature = await this.featureModel
       .findOne({ allIds: featureId })
@@ -111,7 +111,7 @@ export class FeaturesService {
   getFeatureFromId(
     feature: Feature,
     featureId: string,
-    topLevel: boolean,
+    topLevel?: boolean,
     parent?: Feature | null,
   ): Feature | null {
     this.logger.verbose(`Entry=${JSON.stringify(feature)}`)