minor refactoring

sherali42 · May 3, 2020 · f9334f8 · f9334f8
1 parent 9e33ab8
commit f9334f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/rdd/rdd.rs b/src/rdd/rdd.rs
@@ -1029,8 +1029,7 @@ pub trait Rdd: RddBase + 'static {
                     move |mut queue1: BoundedPriorityQueue<Self::Item>,
                           queue2: BoundedPriorityQueue<Self::Item>|
                           -> BoundedPriorityQueue<Self::Item> {
-                        queue1.merge(queue2);
-                        queue1
+                        queue1.merge(queue2)
                     }
                 ))?
                 .unwrap() as BoundedPriorityQueue<Self::Item>;

diff --git a/src/utils/bounded_priority_queue.rs b/src/utils/bounded_priority_queue.rs
@@ -27,7 +27,7 @@ impl<T: Data + Ord> BoundedPriorityQueue<T> {
         }
     }
 
-    pub fn merge(&mut self, other: BoundedPriorityQueue<T>) -> &Self {
+    pub fn merge(mut self, other: BoundedPriorityQueue<T>) -> Self {
         other
             .underlying
             .into_iter()
@@ -43,7 +43,7 @@ impl<T: Data + Ord> BoundedPriorityQueue<T> {
         }
     }
 
-    pub(self) fn maybe_replace_lowest(&mut self, elem: T)
+    fn maybe_replace_lowest(&mut self, elem: T)
     where
         T: Data + Ord,
     {