audio streaming header 関連処理の整理 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
handler.goandhandler_test.gofiles, primarily focusing on improving the packet reading mechanism and enhancing the test coverage. The changes involve refactoring the packet reading logic to use defined constants for header and payload lengths, and adding comprehensive tests for the new packet reading function.Refactoring and Improvements:
handler.go: Introduced constantsHeaderLengthandMaxPayloadLengthto replace hardcoded values in the packet reading logic, making the code more readable and maintainable. [1] [2] [3]handler.go: Simplified thereadPacketWithHeaderfunction to handle packet reading more efficiently and clearly.Test Enhancements:
handler_test.go: Added a new test functionTestReadPacketWithHeaderto cover various scenarios for thereadPacketWithHeaderfunction, ensuring robust test coverage.handler_test.go: Removed redundant test cases for audio streaming headers, as these are now covered by the new test function. [1] [2] [3]