Do not unload namespaces in package cleanup

[shikokuchuo]

Fixes #166.

@wlandau this is my proposed fix. Please let me know if you can think of any corner cases - I can't think how this change would be problematic. Thanks!

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (92afc17) to head (d44736d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           9        9           
  Lines         692      692           
=======================================
  Hits          690      690           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shikokuchuo]

Note that this would then be consistent with namespaces that are not attached in the first place:

library(mirai)
daemons(1)
#> [1] 1
mirai(loadedNamespaces())[]
#>  [1] "compiler"  "graphics"  "utils"     "grDevices" "stats"     "datasets" 
#>  [7] "methods"   "mirai"     "base"      "nanonext"
mirai(data.table::data.table())[]
#> data frame with 0 columns and 0 rows
mirai(loadedNamespaces())[]
#>  [1] "compiler"   "graphics"   "utils"      "grDevices"  "stats"     
#>  [6] "datasets"   "data.table" "methods"    "mirai"      "base"      
#> [11] "nanonext"
daemons(0)
#> [1] 0

^{Created on 2024-11-11 with reprex v2.1.1}

[wlandau]

If this solves #166, then it seems reasonable.

I'm not sure which conditions can reproduce the original data.table-related issue in #166, replicate(100, {library(data.table); detach(name = "package:data.table", unload = TRUE, character.only = TRUE)}) seems to work fine on my end.

[shikokuchuo]

The following reliably crashes for me after a few iterations:

for (i in 1:100) {
  library(data.table); data.table(); detach(name = "package:data.table", unload = TRUE, character.only = TRUE)
}