parse h264 parameter

shinyoshiaki · Nov 9, 2023 · 5f160ec · 5f160ec
1 parent 0cf78e9
commit 5f160ec
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/webrtc/package.json b/packages/webrtc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "werift",
-  "version": "0.18.9",
+  "version": "0.18.11",
   "description": "WebRTC Implementation for TypeScript (Node.js)",
   "keywords": [
     "WebRTC",

diff --git a/packages/webrtc/src/sdp.ts b/packages/webrtc/src/sdp.ts
@@ -669,18 +669,24 @@ export function codecParametersFromString(str: string) {
       } else {
         parameters[k] = v;
       }
+    } else if (param.includes(":")) {
+      const [k, v] = param.split(":");
+      parameters[k] = Number.isNaN(Number(v)) ? v : Number(v);
     } else {
       parameters[param] = undefined;
     }
   });
   return parameters;
 }
 
-export function codecParametersToString(parameters: {
-  [key: string]: string | number;
-}) {
+export function codecParametersToString(
+  parameters: {
+    [key: string]: string | number;
+  },
+  joint: string = "="
+) {
   const params = Object.entries(parameters).map(([k, v]) => {
-    if (v) return `${k}=${v}`;
+    if (v) return `${k}${joint}${v}`;
     else return k;
   });
   if (params.length > 0) {

diff --git a/packages/webrtc/tests/sdp.test.ts b/packages/webrtc/tests/sdp.test.ts
@@ -1,4 +1,9 @@
-import { GroupDescription, MediaDescription, SessionDescription } from "../src";
+import {
+  codecParametersFromString,
+  GroupDescription,
+  MediaDescription,
+  SessionDescription,
+} from "../src";
 
 describe("sdp", () => {
   test("rtx", () => {
@@ -12,4 +17,17 @@ describe("sdp", () => {
       new GroupDescription("FID", ["ssrc", "rtx"]),
     ]);
   });
+
+  describe("codecParametersFromString", () => {
+    test("h264 parameters", () => {
+      const params = codecParametersFromString(
+        "packetization-mode:0;profile-level-id:42001f;level-asymmetry-allowed:0"
+      );
+      expect(params).toEqual({
+        "level-asymmetry-allowed": 0,
+        "packetization-mode": 0,
+        "profile-level-id": "42001f",
+      });
+    });
+  });
 });