Skip to content

Commit

Permalink
Merge pull request #1569 from SaschaSchwarze0/sascha-correct-dockerfi…
Browse files Browse the repository at this point in the history
…le-migration

Do not set dockerfile parameter to an empty string to align with behavior of alpha controller
  • Loading branch information
openshift-merge-bot[bot] authored Apr 4, 2024
2 parents 3a5a8b3 + ae09935 commit 8b1cbe2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/apis/build/v1beta1/build_conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (dest *BuildSpec) ConvertFrom(orig *v1alpha1.BuildSpec) error {
}

//handle spec.Dockerfile migration
if orig.Dockerfile != nil {
if orig.Dockerfile != nil && *orig.Dockerfile != "" {
dockerfileParam := ParamValue{
Name: "dockerfile",
SingleValue: &SingleValue{
Expand Down

0 comments on commit 8b1cbe2

Please sign in to comment.