Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove APIVersion from the Strategy struct #1363

Closed
1 task done
qu1queee opened this issue Aug 22, 2023 · 1 comment · Fixed by #1398
Closed
1 task done

[FEATURE] Remove APIVersion from the Strategy struct #1363

qu1queee opened this issue Aug 22, 2023 · 1 comment · Fixed by #1398
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Aug 22, 2023

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

The Strategy struct do not need an APIVersion at all

Describe the solution that you would like.

type Strategy struct {
	// Name of the referent; More info: http://kubernetes.io/docs/user-guide/identifiers#names
	Name string `json:"name"`

	// BuildStrategyKind indicates the kind of the buildstrategy, namespaced or cluster scoped.
	Kind *BuildStrategyKind `json:"kind,omitempty"`

	// API version of the referent
	// +optional
	APIVersion *string `json:"apiVersion,omitempty"`
}

to

type Strategy struct {
	// Name of the referent; More info: http://kubernetes.io/docs/user-guide/identifiers#names
	Name string `json:"name"`

	// BuildStrategyKind indicates the kind of the buildstrategy, namespaced or cluster scoped.
	Kind *BuildStrategyKind `json:"kind,omitempty"`
}

Describe alternatives you have considered.

none

Anything else?

As part of the upcoming v0.12.0 release

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2023
@qu1queee qu1queee added this to the release-v0.12.0 milestone Aug 22, 2023
@apoorvajagtap apoorvajagtap moved this to In Progress in Shipwright Overview Aug 24, 2023
@apoorvajagtap apoorvajagtap moved this from In Progress to Todo in Shipwright Overview Aug 24, 2023
@apoorvajagtap apoorvajagtap moved this from Todo to In Progress in Shipwright Overview Aug 29, 2023
@qu1queee
Copy link
Contributor Author

From refinement, work in progress.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Shipwright Overview Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants