Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Strategy.APIversion #1398

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Removing Strategy.APIversion #1398

merged 1 commit into from
Oct 12, 2023

Conversation

apoorvajagtap
Copy link
Member

Changes

Fixes #1363

-->

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The Strategy struct does not have an APIVersion field anymore.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Oct 9, 2023
@openshift-ci openshift-ci bot requested review from adambkaplan and qu1queee October 9, 2023 16:56
@apoorvajagtap
Copy link
Member Author

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2023
@apoorvajagtap apoorvajagtap force-pushed the issue_1363_upstream branch 6 times, most recently from 87fc989 to 2ef326b Compare October 10, 2023 05:19
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 10, 2023
qu1queee
qu1queee approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @apoorvajagtap

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci openshift-ci bot merged commit 4bd3b46 into shipwright-io:main Oct 12, 2023
11 checks passed
@apoorvajagtap apoorvajagtap deleted the issue_1363_upstream branch October 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@qu1queee qu1queee

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Remove APIVersion from the Strategy struct
3 participants
@apoorvajagtap @qu1queee @SaschaSchwarze0