Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Order of Local Source between Builds and BuildRuns #1500

Closed
1 task done
qu1queee opened this issue Feb 20, 2024 · 1 comment · Fixed by #1510
Closed
1 task done

[BUG] Order of Local Source between Builds and BuildRuns #1500

qu1queee opened this issue Feb 20, 2024 · 1 comment · Fixed by #1510
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@qu1queee
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

No response

Shipwright Version

No response

Current Behavior

When it come to Local Source, it seems we will always take the definition of the source of a Build, rather than the one from a BuildRun, see https://github.com/shipwright-io/build/blob/main/pkg/reconciler/buildrun/resources/sources.go#L27-L43

Expected Behavior

The definition of a Local Source in a BuildRun, should override the Build.

Steps To Reproduce

No response

Anything else?

No response

@qu1queee qu1queee added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
@qu1queee
Copy link
Contributor Author

From Refinement, we think the use-case for getting into this scenario are low, putting as Low Prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
1 participant