[fixed] : Order of Local Source between Builds and BuildRuns

[Adarsh-jaiss]

Changes

This Pull Request fixes #1500 by improving the "isLocalCopyBuildSource" function by reordering the conditionals to prioritize the local source from the BuildRun over that of the Build. Here's a summary of the changes made:

• The check for the local source in the BuildRun is moved to the top of the function. This adjustment ensures that if a local source is defined in the BuildRun, it will be returned without further checks.
• If no local source is found in the BuildRun, the function then checks if the Build has a local source defined and returns it if found.
• If neither the BuildRun nor the Build has a local source defined, the function returns nil.
  Removed redundant condition:

With the first conditional handling the case where a local source is defined in the BuildRun, there's no need to check if the Build has a local source if the BuildRun already has one.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign otaviof for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[HeavyWombat]

The comment becomes an orphan by your change, nonetheless we think this comment can be removed anyway. Could you amend that in your change?

[Adarsh-jaiss]

Yeah sure @HeavyWombat . will do it ASAP!

[SaschaSchwarze0]

Can you please rebase your branch. Commit "Fixed buildCredentialserences function name" was already merged in #1506.

Also, please check the release notes section of your PR description. You need to remove the HTML comment (<!-- -->) and select one section like I had done it for you in your previous PR.

[Adarsh-jaiss]

I think i have messed up a lot of things. I'll just create a new PR