Handle dockerfile in build strategy conversion #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/feature
openshift-ci
bot
added
the
release-note-none
pull-request-size
bot
added
the
size/L
SaschaSchwarze0
force-pushed
the
sascha-dockerfile
branch
from
6b623ea to
b138922
Compare
qu1queee
approved these changes
Sep 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
qu1queee
reviewed
Sep 19, 2023
| if usesDockerfile { | ||
| src.Parameters = append(src.Parameters, Parameter{ | ||
| Name: "dockerfile", | ||
| Description: "The Dockerfile to be built.", |
There was a problem hiding this comment.
ideally we should inline this and https://github.com/shipwright-io/build/pull/1352/files#diff-7cd8b697dab952af9e04af485edc3ac5c177272bbf432f2fb9f13b86ae144b6eR56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change completes the handling of Dockerfiles:
$(build.dockerfile)or$(params.DOCKERFILE)gets their usage migrated to$(params.dockerfile)and the dockerfile parameter is declared$(params.DOCKERFILE)I am also adding a commit that fixes the conversion of the retention from alpha to beta. The old code worked find in unit tests but not in reality. We must create a copy of the Map so that the annotation addition works.
Submitter Checklist
Release Notes