Fix Heruko buildpacks samples that failed to determine the target OS #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
openshift-ci
bot
added
the
release-note-none
Ref: heroku/buildpacks-procfile#214 Ref: heroku/libcnb.rs@033f612 Add `CNB_TARGET_OS` and `CNB_TARGET_ARCH` to fix error during the detect phase, where the target system cannot be detected: ``` [Error: Internal Buildpack Error] Couldn't determine target os: environment variable not found err: heroku/[email protected] (1) ======== Output: heroku/[email protected] ======== ``` There seems to be a changed behavior that was introduced in the common buildpacks library that is in use that expects these environment variables to be present to detect the target system OS and architecture. Signed-off-by: Matthias Diester <[email protected]>
HeavyWombat
force-pushed
the
tweak/heruko-buildpacks-samples
branch
from
1beb274 to
c2d4725
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
SaschaSchwarze0
added
kind/failing-test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
CNB_TARGET_OSandCNB_TARGET_ARCHto fix error during the detect phase, where the target system cannot be detected:There seems to be a changed behavior that was introduced in the common buildpacks library that is in use that expects these environment variables to be present to detect the target system OS and architecture.
Ref: heroku/buildpacks-procfile#214
Ref: heroku/libcnb.rs@033f612
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes