Add StepOutOfMemory as reason for BuildRun failure #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/feature
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/L
qu1queee
requested changes
May 2, 2024
qu1queee
reviewed
May 3, 2024
SaschaSchwarze0
force-pushed
the
sascha-container-oom
branch
from
f3db058 to
8c86adf
Compare
SaschaSchwarze0
force-pushed
the
sascha-container-oom
branch
from
8c86adf to
1957e5d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a BuildRun Pod fails because of too much ephemeral storage usage and is therefore evicted, then we expose this nicely in the BuildRun status as the condition reason is set to PodEvicted. In case a container went out of memory, we did not expose that at all in the BuildRun status while it is quite obvious in the TaskRun and Pod status who print the step/container status.
I am therefore proposing here to introduce the BuildRun failure reason StepOutOfMemory.
Submitter Checklist
Release Notes