Add script for storage version migartion of crds #1646
Conversation
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/L
|
/kind feature |
openshift-ci
bot
added
the
kind/feature
karanibm6
force-pushed
the
storage-version-migration
branch
from
ee3c75c to
142e244
Compare
deploy/200-role.yaml
Outdated
|
|
||
| - apiGroups: ['apiextensions.k8s.io'] | ||
| resources: ['customresourcedefinitions', 'customresourcedefinitions/status'] | ||
| verbs: ['get', 'list', 'watch', 'create', 'update', 'delete', 'patch'] |
There was a problem hiding this comment.
Can you reduce this. Our controller and the migration script will never create or delete them. I guess overall we might be fine with just get and patch. Can you try?
There was a problem hiding this comment.
I tried and it worked.
hack/storage-version-migration.sh
Outdated
| labels: | ||
| app: storage-version-migration-shipwright | ||
| app.kubernetes.io/component: storage-version-migration-job | ||
| app.kubernetes.io/name: shipwright-build | ||
| app.kubernetes.io/version: devel |
There was a problem hiding this comment.
@SaschaSchwarze0 Do you mean, just this label app.kubernetes.io/version: devel or all the labels ?
hack/storage-version-migration.sh
Outdated
| annotations: | ||
| sidecar.istio.io/inject: "false" | ||
| labels: | ||
| app: storage-version-migration-shipwright | ||
| app.kubernetes.io/component: storage-version-migration-job | ||
| app.kubernetes.io/name: shipwright-build | ||
| app.kubernetes.io/version: devel |
hack/storage-version-migration.sh
Outdated
|
|
||
| if [ "${isFailed}" == "True" ]; then | ||
| echo "[ERROR] Storage version migration failed" | ||
| kubectl -n shipwright-build logs "job/${JOB_NAME}" | grep -v "Kubernetes default value is insecure" |
There was a problem hiding this comment.
This grep filters out a message from the Knative Serving webhook when it validates KSvcs. Is unnecessary here.
| kubectl -n shipwright-build logs "job/${JOB_NAME}" | grep -v "Kubernetes default value is insecure" | |
| kubectl -n shipwright-build logs "job/${JOB_NAME}" |
karanibm6
force-pushed
the
storage-version-migration
branch
from
142e244 to
dd9857d
Compare
karanibm6
force-pushed
the
storage-version-migration
branch
from
dd9857d to
cfd1a39
Compare
karanibm6
force-pushed
the
storage-version-migration
branch
from
c82a6e3 to
3c97d19
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Changes
Add script for storage version migartion of crds
Fixes #1603
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes