fixed container name for shipwright-webhook

[Adarsh-jaiss]

Changes

• Fixed container name for shipwright-webhook from shp-build-webhook to shipwright-build-webhook
• Fixes [BUG] The container name for shipwright build webhook doesn't match the environment variable #1648

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

[SaschaSchwarze0]

I had not seen that issue before. But question. Changing the container name. That would only be for future Shipwright Build releases. In Operator, is that fixable through other means or given its version is "connected" toa Shipwright Build version, it would also not help?

[adambkaplan]

/approve

@SaschaSchwarze0 So this would have an impact on the operator, but not in the way you would expect. We have operator logic that modifies the deployed image based on an environment variable. We pattern match the container name to the environment variable - changing the container name means we need to update the env var name.

I'm OK with this - it brings consistency to those environment variables. This is a minor change that can be addressed once this PR merges and we update the operator with the next nightly release manifest.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SaschaSchwarze0]

/lgtm