Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log into GitHub Container Registry for unit test #1691

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

HeavyWombat
Copy link
Contributor

@HeavyWombat HeavyWombat commented Sep 26, 2024

Ref: #1689

Changes

Log into GitHub Container Registry for unit test so that Trivy database download can be done in an authenticated context.

Potentially mitigates (parts of) #1689

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2024
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note kind/bug Categorizes issue or PR as related to a bug. labels Sep 26, 2024
Ref: #1689

Log into GitHub Container Registry for unit test so that Trivy database
download can be done in an authenticated context.

Signed-off-by: Matthias Diester <[email protected]>
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0fb343c into main Sep 27, 2024
19 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the mitigate/rate-limiting branch September 27, 2024 10:42
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants