Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file listing for bundle unpack and Git clone #1702

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

HeavyWombat
Copy link
Contributor

@HeavyWombat HeavyWombat commented Oct 28, 2024

Changes

Add flag to enable to print a file listing when the unpacking of a source bundle or Git clone is complete.

Output looks like this:

$ bundle --image ghcr.io/shipwright-io/sample-go/source-bundle:latest --target /tmp/workspace/source --show-listing
2024/10/29 13:04:34 Pulling image "ghcr.io/shipwright-io/sample-go/source-bundle:latest"
2024/10/29 13:04:34 Image content was extracted to /tmp/workspace/source
 -rw-r--r--  1  501  0  11.1K  LICENSE
 -rw-r--r--  1  501  0   249B  OWNERS
 -rw-r--r--  1  501  0   1.3K  README.md
 drwxr-xr-x  4  501  0   128B  docker-build
 -rw-r--r--  1  501  0   381B  docker-build/Dockerfile
 -rw-r--r--  1  501  0   972B  docker-build/main.go
 drwxr-xr-x  4  501  0   128B  docker-build-with-args
 -rw-r--r--  1  501  0   528B  docker-build-with-args/Dockerfile
 -rw-r--r--  1  501  0   972B  docker-build-with-args/main.go
 drwxr-xr-x  4  501  0   128B  source-build
 -rw-r--r--  1  501  0    35B  source-build/go.mod
 -rw-r--r--  1  501  0   972B  source-build/main.go
 drwxr-xr-x  4  501  0   128B  source-build-with-package
 -rw-r--r--  1  501  0    35B  source-build-with-package/go.mod
 drwxr-xr-x  3  501  0    96B  source-build-with-package/main-package
 -rw-r--r--  1  501  0   972B  source-build-with-package/main-package/main.go

/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Added flag to bundle-step and git-step command to print a file listing when pull and unpack of the source bundle, or Git clone is complete.

@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note kind/feature Categorizes issue or PR as related to a new feature. labels Oct 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Oct 28, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some questions.

go.mod Outdated Show resolved Hide resolved
cmd/bundle/main.go Outdated Show resolved Hide resolved
cmd/bundle/main.go Outdated Show resolved Hide resolved
@HeavyWombat HeavyWombat changed the title Add file listing for bundle unpacking Add file listing for bundle unpack and Git clone Oct 29, 2024
Add flag to enable to print a file listing when the unpacking or cloning
of a source bundle is complete.

Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c6a9159 into main Oct 30, 2024
21 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the add/file-listing branch October 30, 2024 09:36
HeavyWombat added a commit that referenced this pull request Nov 4, 2024
Follow-up from #1702 to add the
total size in bytes of all files and the total number of files to the file
listing so that its immediately visible.

Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants