Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.18 #118

Merged
merged 1 commit into from
May 23, 2022
Merged

Update Go to 1.18 #118

merged 1 commit into from
May 23, 2022

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Updating everything to Go 1.18.

Fixes #115

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

We now build our binaries with Go 1.18

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label May 16, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.10.0 milestone May 16, 2022
@openshift-ci openshift-ci bot requested review from adambkaplan and sbose78 May 16, 2022 19:20
qu1queee
qu1queee approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7561e27 into shipwright-io:main May 23, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-go-1.18 branch October 18, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Milestone
release-v0.10.0
Development

Successfully merging this pull request may close these issues.

Move to Go 1.18
3 participants
@SaschaSchwarze0 @qu1queee @openshift-merge-robot