Skip to content

Commit

Permalink
fix permissions for shipwright-build-webhook service
Browse files Browse the repository at this point in the history
  • Loading branch information
jkhelil committed Sep 25, 2023
1 parent f244a06 commit efbe283
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ $ kubectl apply -f https://operatorhub.io/install/shipwright-operator.yaml
```

## OLM Dependencies
When installed via OLM using the provided SHipwright Operator Bundle, the Shipwright operator has two dependencies to:
- The Tekton operator needed by the Shipright Build Controller
- The Cert-Manager operator needed in case you delegate to the Shipwright operator the ssl certificates management of the Shipwright Conversion webhook
The two operators are then installed automatically by OLM.
When installed via OLM using the provided Shipwright Operator Bundle, the Shipwright operator will ask OLM to deploy the following operators:
- The [Tekton operator](https://tekton.dev/docs/operator/) to deploy and manage Tekton Pipelines.
- The [Cert-Manager operator](https://cert-manager.io/docs/installation/operator-lifecycle-manager/) to provision certificates for admission/conversion webhooks.
For this to work, the Shipwright operator must be included in a catalog that includes these other operators.

## Usage

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ spec:
- apiGroups:
- ""
resourceNames:
- shipwright-build-controller
- shipwright-build-webhook
resources:
- services
verbs:
Expand Down
2 changes: 1 addition & 1 deletion config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ rules:
- apiGroups:
- ""
resourceNames:
- shipwright-build-controller
- shipwright-build-webhook
resources:
- services
verbs:
Expand Down
2 changes: 1 addition & 1 deletion controllers/shipwrightbuild_rbac.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ package controllers
// +kubebuilder:rbac:groups=cert-manager.io,resources=certificates,verbs=get;list;watch;create
// +kubebuilder:rbac:groups=cert-manager.io,resources=certificates,resourceNames=shipwright-build-webhook-cert,verbs=update;patch;delete
// +kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create
// +kubebuilder:rbac:groups=core,resources=services,resourceNames=shipwright-build-controller,verbs=update;patch;delete
// +kubebuilder:rbac:groups=core,resources=services,resourceNames=shipwright-build-webhook,verbs=update;patch;delete
// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;create
// +kubebuilder:rbac:groups=core,resources=secrets,resourceNames=shipwright-build-webhook-cert,verbs=update;patch;delete

0 comments on commit efbe283

Please sign in to comment.