Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump shipwright build 0.12.0 #152

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Bump shipwright build 0.12.0 #152

merged 2 commits into from
Oct 25, 2023

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Oct 23, 2023 •
edited
Loading

Changes

  • Update shipwright build with version 0.12.0
  • Add missing operator service account rbac required by webhook serviceaccount
  • fixes webhook cert handling:
    • Certificate dnsName needs dnsNames injection through manifestival transformation due to presence of the namespace in the domain name (not handled natively by manifestival)
    • CRD caBundle injection through cert manager annotation needed to be done through manifestival transformation and due to namespace presence (not handled natively by manifestival)
    • Transformation applies only for platform other than Openshift as Openshift has its own service cert management

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

  • Update shipwright build with version 0.12.0
  • Add missing operator service account rbac required by webhook serviceaccount
  • Fixes webhook cert handling:
    • Certificate dnsName needs dnsNames injection through manifestival transformation
    • CRD caBundle injection through cert manager annotation needed to be done through manifestival transformation and due to namespace presence
    • Transformation applies only for platform other than Openshift as Openshift has its own service cert management

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 23, 2023
@openshift-ci openshift-ci bot requested review from adambkaplan and otaviof October 23, 2023 10:30
@jkhelil
Copy link
Contributor Author

jkhelil commented Oct 23, 2023

@shipwright-io/operator-reviewers

@jkhelil
Copy link
Contributor Author

jkhelil commented Oct 23, 2023

/assign @adambkaplan PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@jkhelil: GitHub didn't allow me to assign the following users: PTAL.

Note that only shipwright-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @adambkaplan PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SaschaSchwarze0
SaschaSchwarze0 reviewed Oct 24, 2023
View reviewed changes
kodata/certificates.yaml Outdated
- shipwright-build-webhook.shipwright-build.svc
- shipwright-build-webhook.shipwright-build.svc.cluster.local
- shp-build-webhook.shipwright-build.svc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this ? The service is named "shp-build-webhook". Should not there only that be in? Also, are you sure that we never need cluster.local ? I never questioned it, but we basically always create certificates for our webhooks with svcname, svcname.namespace, svcname.namespace.svc, and svcname.namespace.svc.cluster.local like in https://github.com/shipwright-io/build/blob/main/hack/setup-webhook-cert.sh#L32-L35.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed shp-build-webhook to shiwpright-build-webhook to harmonize naming for the object created via the operator, I kept shp-build-webhook though
I think to avoid confusion, I will keep only shp-build-webhook and raise a PR on the build project to rename shp-build-webhook
and yes we dont need cluster.local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

pkg/certmanager/cert_manager.go Outdated
"shipwright-build-webhook.%s.svc",
"shp-build-webhook.%s.svc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I assume we only need shp-build-webhook.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, I will keep just shp-build-webhook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/apprope
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@openshift-ci openshift-ci bot merged commit 568d49e into shipwright-io:main Oct 25, 2023
3 checks passed
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@adambkaplan adambkaplan

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkhelil @SaschaSchwarze0 @adambkaplan