Run operator as non-root #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
kind/bug
|
/hold This should merge after #29 |
openshift-ci
bot
added
the
do-not-merge/hold
adambkaplan
force-pushed
the
run-as-nonroot
branch
from
3b80b67 to
593e4a0
Compare
|
Now should merge after #31 |
adambkaplan
force-pushed
the
run-as-nonroot
branch
from
593e4a0 to
7ae693f
Compare
4 tasks
|
I posted a comment related to this one in #28 about validating / ensuring we are running as non-root /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
- Run operator as non-root instead of a fixed UID. This fixes issues with OpenShift security context constraints. - Regenerate bundle - Run kube-rbac-proxy with a high UID. The kube-rbac-proxy image by default runs as root. In order to enforce the `runAsNonRoot` at the pod level, give the rbac-proxy container an arbitrarily high UID.
adambkaplan
force-pushed
the
run-as-nonroot
branch
from
7ae693f to
aa0c7f6
Compare
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Run operator as non-root instead of a fixed UID. This fixes issues with OpenShift security context constraints.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
/kind bug
Release Notes