Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

.act-github/workflows/use-github-actions.yml

@@ -22,17 +22,17 @@ jobs:
                 python3-setuptools rsync silversearcher-ag strip-nondeterminism valgrind
                 vim xsltproc
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then     sudo rm
-                -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then sudo rm -fr
+                ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then     sudo rm
-                -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then sudo rm -fr
+                ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then . fc-solve/scripts/ci-install-stage.bash
-                ; elif test "$WHAT" = "buildproc"; then . fc-solve/scripts/ci-docker-test--install.bash
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then . fc-solve/scripts/ci-install-stage.bash
+                ; elif test "$WHAT" = "buildproc" ; then . fc-solve/scripts/ci-docker-test--install.bash
                 ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then export XML_CATALOG_FILES="/etc/xml/catalog
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then export XML_CATALOG_FILES="/etc/xml/catalog
                 $HOME/markup-validator/htdocs/sgml-lib/catalog.xml" ; bash fc-solve/scripts/run-ci-tests.bash
                 ; elif test "$WHAT" = "buildproc" ; then cd fc-solve/source/ && perl
                 ../scripts/docker-test.pl ; fi

.github/workflows/use-github-actions.yml

@@ -21,17 +21,17 @@ jobs:
                 python3-setuptools rsync silversearcher-ag strip-nondeterminism valgrind
                 vim xsltproc
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then     sudo rm
-                -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then sudo rm -fr
+                ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then     sudo rm
-                -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then sudo rm -fr
+                ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then . fc-solve/scripts/ci-install-stage.bash
-                ; elif test "$WHAT" = "buildproc"; then . fc-solve/scripts/ci-docker-test--install.bash
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then . fc-solve/scripts/ci-install-stage.bash
+                ; elif test "$WHAT" = "buildproc" ; then . fc-solve/scripts/ci-docker-test--install.bash
                 ; fi
         -   run: local_lib_shim() { eval "$(perl -Mlocal::lib=$HOME/perl_modules)";
-                } ; local_lib_shim ; if test "$WHAT" = "normal"; then export XML_CATALOG_FILES="/etc/xml/catalog
+                } ; local_lib_shim ; if test "$WHAT" = "normal" ; then export XML_CATALOG_FILES="/etc/xml/catalog
                 $HOME/markup-validator/htdocs/sgml-lib/catalog.xml" ; bash fc-solve/scripts/run-ci-tests.bash
                 ; elif test "$WHAT" = "buildproc" ; then cd fc-solve/source/ && perl
                 ../scripts/docker-test.pl ; fi

.travis.yml

@@ -49,14 +49,14 @@ language: c
 python:
     - '3.6'
 before_install:
-    - if test "$WHAT" = "normal"; then     sudo rm -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
+    - if test "$WHAT" = "normal" ; then sudo rm -fr ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
 install:
-    - if test "$WHAT" = "normal"; then     sudo rm -fr ~/gopath ;. fc-solve/scripts/ci-before-install.bash ; fi
-    - if test "$WHAT" = "normal"; then . fc-solve/scripts/ci-install-stage.bash ; elif test "$WHAT" = "buildproc"; then . fc-solve/scripts/ci-docker-test--install.bash ; fi
+    - if test "$WHAT" = "normal" ; then sudo rm -fr ~/gopath ; . fc-solve/scripts/ci-before-install.bash ; fi
+    - if test "$WHAT" = "normal" ; then . fc-solve/scripts/ci-install-stage.bash ; elif test "$WHAT" = "buildproc" ; then . fc-solve/scripts/ci-docker-test--install.bash ; fi
 perl:
     - "5.24"
 script:
-    - if test "$WHAT" = "normal"; then export XML_CATALOG_FILES="/etc/xml/catalog $HOME/markup-validator/htdocs/sgml-lib/catalog.xml" ; bash fc-solve/scripts/run-ci-tests.bash ; elif test "$WHAT" = "buildproc" ; then cd fc-solve/source/ && perl ../scripts/docker-test.pl ; fi
+    - if test "$WHAT" = "normal" ; then export XML_CATALOG_FILES="/etc/xml/catalog $HOME/markup-validator/htdocs/sgml-lib/catalog.xml" ; bash fc-solve/scripts/run-ci-tests.bash ; elif test "$WHAT" = "buildproc" ; then cd fc-solve/source/ && perl ../scripts/docker-test.pl ; fi
 cache:
     ccache: true
     directories: