Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcasters: add Typhoon BlueWeather, minor fix for ATC1441 #124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

relghuar
Copy link

- add support for BLE broadcaster Typhoon BlueWeather TB002
  (http://typhoon.de/Produkte_Typhoon/Gesundheit/BlueWeather.htm)
- fix structure format and MAC address encoding for ATC1441
  (works with https://github.com/pvvx/ATC_MiThermometer firmware v3.1+)
@shmuelzon
Copy link
Owner

Hey @relghuar,

Thank you for the pull request!
The logic itself looks fine but the code style doesn't fit with the rest of the project:

  • I don't prefix variables/structure fields according to their type
  • No need to wrap single-line blocks with curly braces
  • Single space between operands
  • Defining all variables at the beginning of the block
  • Snake case

Would you like me to fix the pull request myself instead of adding a comment for each location or would you rather fix it yourself?

@shmuelzon shmuelzon force-pushed the master branch 2 times, most recently from 7c19828 to 6ebee2a Compare October 11, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants