Input the contacts in parallel from numpy #2
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 62.09% 64.27% +2.18%
==========================================
Files 8 8
Lines 910 985 +75
==========================================
+ Hits 565 633 +68
- Misses 345 352 +7
☔ View full report in Codecov by Sentry. |
bp.cpp
Outdated
| void FactorGraph::check_neighbors(int i, int j){ | ||
| if (i == j) | ||
| throw invalid_argument("self loops are not allowed"); | ||
| add_node(i); |
There was a problem hiding this comment.
Qui e dopo: abbiamo usato tabs e non spazi per il codice in c++
bp.cpp
Outdated
| add_node(j); | ||
| add_node(i); | ||
| add_node(j); | ||
| //node i |
There was a problem hiding this comment.
questo commento non agigunge niente, toglierei
bp.cpp
Outdated
| Node & fi = nodes[i]; | ||
| //node j |
| @@ -102,6 +103,8 @@ class FactorGraph { | |||
| std::vector<std::tuple<int, std::shared_ptr<Proba>, std::shared_ptr<Proba>, std::shared_ptr<Proba>, std::shared_ptr<Proba>> > const & individuals = std::vector<std::tuple<int, std::shared_ptr<Proba>, std::shared_ptr<Proba>, std::shared_ptr<Proba>, std::shared_ptr<Proba>>>()); | |||
| int find_neighbor(int i, int j) const; | |||
| void append_contact(int i, int j, times_t t, real_t lambdaij, real_t lambdaji = DO_NOT_OVERWRITE); | |||
| void check_neighbors(int i, int j); | |||
There was a problem hiding this comment.
l'aggiunta di queste due funzioni sembrano gli unici cambiamenti "veri" in bp.h e bp.cpp. Puoi lasciare solo questo in questo PR?
grazie mille fabio
ab changes
fabmazz
force-pushed
the
par_contacts
branch
from
25bc86c to
a70728f
Compare
No description provided.