-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluator fix #97
Evaluator fix #97
Conversation
… into fuature/evaluator
@lisicky any ideas what this linting about? actually probably can ignore for now but want to see if you have thoughts |
@lisicky any ideas what this linting about? actually probably can ignore for now but want to see if you have thoughts @HinsonSIDAN it’s about that the function is not used. We can drop this function, but I would left it for future |
Ok i make it a publicly accessible function for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
This pull request introduces several improvements and fixes to the
sidan-csl-rs
crate, particularly in the areas of transaction script evaluation and network type handling. The changes include passing references instead of values, adding error text for better debugging, fixing network deserialization, and introducing new tests to ensure the reliability of these changes.Type of Change
Feature Change
sidan-csl-rs
- Feature updateMaintenance
Checklist
Additional Information
The main changes in this pull request include:
evaluate_tx_scripts_js
function to passresolved_utxos
andadditional_txs
by reference, improving memory management.TryFrom<String>
forNetwork
enum to enhance network type parsing.as_ref_vec
method toJsVecString
for better reference handling.