Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

지난 주 인기 프로젝트 목록 조회(배너용) 구현 #147

Merged
merged 37 commits into from
Mar 13, 2024
Merged

지난 주 인기 프로젝트 목록 조회(배너용) 구현 #147

merged 37 commits into from
Mar 13, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Mar 12, 2024 •
edited
Loading

🎫 관련 이슈

Resolves #146
Resolves #155

✅ 구현 내용

  • 지난 주 인기 프로젝트 목록 조회(배너용) 컨트롤러 구현
  • 지난 주 인기 프로젝트 목록 조회(배너용) 스웨거 작성
  • 배너용 프로젝트 응답 ProjectBannerResponse 구현
  • 테스트 코드 작성

2024.03.13

  • 지난 주 좋아요를 많이 받은 프로젝트 로직 작성

💬 코멘트

  • 컨트롤러만 먼저 만들려다가 우선 빠르게 기능 구현 해보았습니다,,!
  • 테스트 코드는 나눠서 올리거나 리뷰가 없을때 한 번 더 푸시 하겠습니다! -> 작성 완료!

@Sehee-Lee-01 Sehee-Lee-01 self-assigned this Mar 12, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@Sehee-Lee-01 Sehee-Lee-01 changed the title 금주의 인기 프로젝트 목록 조회(배너용) 컨트롤러 구현 금주의 인기 프로젝트 목록 조회(배너용) 구현 Mar 12, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
uijin-j
uijin-j reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@uijin-j uijin-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스크 생기면 바로바로 해주셔서 너무 감사합니다🥹🥹💛

src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustom.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustomImpl.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/service/ProjectService.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustomImpl.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/service/ProjectService.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

📝 Jacoco Test Coverage

Overall Project 69.8% -0.52% ❌
Files changed 78.32% ❌

File Coverage
ProjectBannerResponse.java 100% 🍏
ProjectService.java 92.04% 🍏
ProjectRepositoryCustomImpl.java 46.92% 🍏
ProjectController.java 0% -41.89% ❌

yenzip
yenzip approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@yenzip yenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! ❤️‍🔥

src/main/java/sixgaezzang/sidepeek/projects/service/ProjectService.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/util/ProjectConstant.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustomImpl.java Outdated Show resolved Hide resolved
@Sehee-Lee-01
Merge branch 'dev' into feat/#146-weekly-popular-projects
a116dd5 
# Conflicts:
#	src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustom.java
#	src/main/java/sixgaezzang/sidepeek/projects/repository/ProjectRepositoryCustomImpl.java
#	src/main/java/sixgaezzang/sidepeek/projects/service/ProjectService.java
#	src/test/java/sixgaezzang/sidepeek/projects/service/ProjectServiceTest.java
#	src/test/java/sixgaezzang/sidepeek/util/FakeEntityProvider.java
@Sehee-Lee-01
fix: merge 충돌 해결
3adcfc2
@Sehee-Lee-01
chore: secret 변경 반영
07fbb17
@Sehee-Lee-01
Merge branch 'dev' into feat/#146-weekly-popular-projects
498b210 
# Conflicts:
#	src/main/java/sixgaezzang/sidepeek/common/doc/ProjectControllerDoc.java
#	src/main/java/sixgaezzang/sidepeek/projects/controller/ProjectController.java
#	src/main/java/sixgaezzang/sidepeek/projects/service/ProjectService.java
#	src/test/java/sixgaezzang/sidepeek/projects/service/ProjectServiceTest.java
@Sehee-Lee-01
fix: merge 충돌 해결
bfbfd80
@Sehee-Lee-01
style: 2줄 공백 수정
65e5d87
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@Sehee-Lee-01
refactor: BANNER_PROJECT_COUNT int로 변경
cc6ebb9
@Sehee-Lee-01
feat: DateUtils 정의 및 메서드 구현
668b526
@Sehee-Lee-01
feat: DateUtils 메서드 적용
569c145
@Sehee-Lee-01
feat: ProjectBannerResponse에 불필요한 인자 삭제
3015d31
@Sehee-Lee-01
feat: 지난 주 좋아요 기록을 project로 그룹지은 후 개수가 가장 많은 프로젝트 5개를 선별하는 로직 구현
bd692d1
@Sehee-Lee-01
style: JavaDoc 줄바꿈 수정
7ea1e3e
@Sehee-Lee-01
refactor: findAllPopularLastWeek로 메서드명 변경
7958d98
@Sehee-Lee-01
feat: DateTimeProvider로 서비스 코드와 현재 시간 의존성 분리
7204fe1
@Sehee-Lee-01
test: 지난_주_인기_프로젝트_조회_테스트 작성
24cc2d2
@Sehee-Lee-01
Merge branch 'dev' into feat/#146-weekly-popular-projects
8628977 
# Conflicts:
#	src/main/java/sixgaezzang/sidepeek/common/doc/ProjectControllerDoc.java
#	src/main/java/sixgaezzang/sidepeek/projects/controller/ProjectController.java
#	src/main/java/sixgaezzang/sidepeek/projects/repository/project/ProjectRepositoryCustom.java
#	src/main/java/sixgaezzang/sidepeek/projects/repository/project/ProjectRepositoryCustomImpl.java
@Sehee-Lee-01
refactor: ProjectController 순서 재배치 및 충돌 수정
54e1e6b
@Sehee-Lee-01
refactor: 현재 불가능한 테스트 주석처리
ed5e99b
@Sehee-Lee-01 Sehee-Lee-01 changed the title 금주의 인기 프로젝트 목록 조회(배너용) 구현 지난 주 인기 프로젝트 목록 조회(배너용) 구현 Mar 13, 2024
@github-actions GitHub Actions
Copy link

📝 Jacoco Test Coverage

Overall Project 71.37% -0.46% ❌
Files changed 81.18% 🍏

File Coverage
DateUtils.java 100% 🍏
ProjectBannerResponse.java 100% 🍏
LoginRequest.java 100% 🍏
ReissueTokenRequest.java 100% 🍏
Project.java 97.69% 🍏
ValidationUtils.java 97.66% 🍏
User.java 92.82% -1.66% ❌
ProjectService.java 92.78% 🍏
ProjectRepositoryCustomImpl.java 48.68% 🍏
DateTimeProvider.java 42.86% -57.14% ❌
GlobalExceptionHandler.java 3.27% 🍏
ProjectController.java 0% -37.31% ❌

@Sehee-Lee-01 Sehee-Lee-01 merged commit c86b3e7 into dev Mar 13, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the feat/#146-weekly-popular-projects-controller branch March 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenzip yenzip yenzip approved these changes

@uijin-j uijin-j Awaiting requested review from uijin-j uijin-j is a code owner

Assignees

@Sehee-Lee-01 Sehee-Lee-01

Labels
✏️ 기록혀야쥬 문서 기록 🚀 더 만들어봤슈 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sehee-Lee-01 @uijin-j @yenzip