댓글 생성 및 삭제 시 댓글 수 업데이트 안 되는 버그 해결 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
3 tasks
Sehee-Lee-01
approved these changes
Mar 14, 2024
src/main/java/sixgaezzang/sidepeek/comments/service/CommentService.java
Outdated
Show resolved
Hide resolved
| @@ -79,15 +78,15 @@ public static ProjectResponse from(Project project, List<OverviewImageSummary> o | |||
| .deployUrl(project.getDeployUrl()) | |||
| .viewCount(project.getViewCount()) | |||
| .likeCount(project.getLikeCount()) | |||
| .commentCount(comments.commentCount()) // 댓글 + 대댓글 | |||
| .commentCount(project.getCommentCount()) // 댓글 + 대댓글 | |||
# Conflicts: # src/main/java/sixgaezzang/sidepeek/projects/domain/Project.java # src/main/resources/db/data/afterMigrate.sql
Comment on lines
456
to
470
| @Test | ||
| void 대댓글이_있는_댓글_삭제에_성공한다() { | ||
| // given, when | ||
| // given | ||
| Comment subComment = createAndSaveComment(user, null, comment); | ||
| Long initialCommentCount = project.getCommentCount(); | ||
|
|
||
| // when | ||
| commentService.delete(user.getId(), comment.getId()); | ||
|
|
||
| // then | ||
| assertThat(commentRepository.findById(comment.getId())).isEmpty(); | ||
| assertThat(commentRepository.findById(subComment.getId())).isEmpty(); | ||
| // TODO: Empty가 아닌 것으로 나오는 이유 알아보기 | ||
| // assertThat(commentRepository.findById(subComment.getId())).isEmpty(); | ||
| assertThat(project.getCommentCount()).isEqualTo(initialCommentCount - 2); | ||
| } |
There was a problem hiding this comment.
현재 주석한 줄 제외하고는 모두 통과 됩니다! JPA 영속성 컨텍스트에서 발생한 문제 같은데 정리해서 나중에 공유하겟습니다! 테스트 코드가 영향이 가서 죄송합니다,,, 여기에 추가로 잘 작성해주셔서 감사합니다!🥰
📝 Jacoco Test Coverage
|
Comment on lines
+12
to
+15
|
|
||
| <!-- TEST 패키지 하위에 대한 VariableDeclarationUsageDistance 검사를 무시 --> | ||
| <suppress checks="VariableDeclarationUsageDistance" | ||
| files=".*src[/\\]test[/\\].*\.java"/> |
There was a problem hiding this comment.
요 부분은 선언한 지역 변수가 assertThat 확인하는 줄과 떨어져 있을 때 발생해서 추가했습니다! 앞으로도 테스트 코드에서 많이 뜰 것 같아서 이 파일에 선언했습니다!
| @@ -45,7 +47,7 @@ public class Comment extends BaseTimeEntity { | |||
| @JoinColumn(name = "user_id") | |||
| private User user; | |||
|
|
|||
| // TODO: @OnDelete(action = OnDeleteAction.CASCADE) 설정을 안해도 돌아간다. 필요할까!(고민중) | |||
| @OnDelete(action = OnDeleteAction.CASCADE) | |||
There was a problem hiding this comment.
전에 TODO 남겨둔 것인데 다른 컬럼들 @column(name = "is_anonymous", nullable = false) 명시적으로 해놓은 것처럼 여기도 명시적으로 남겨두었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #153
✅ 구현 내용
💬 코멘트
대댓글이 존재하는 댓글 삭제 시 대댓글 수 + 댓글 수 까지 삭제되도록 반영했습니다!
테스트 코드 작성하려고 하는데 이상한 부분이 있어 세희 언니와 이야기 나누어보고 작성하도록 하겠습니다!