Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

소셜 로그인 시 닉네임이 이미 우리 서비스에 존재하는 경우 예외를 발생시키는 오류 수정 #208

Merged
merged 4 commits into from
Mar 20, 2024
Merged

소셜 로그인 시 닉네임이 이미 우리 서비스에 존재하는 경우 예외를 발생시키는 오류 수정 #208

merged 4 commits into from
Mar 20, 2024

Conversation

uijin-j
Copy link
Contributor

@uijin-j uijin-j commented Mar 20, 2024

🎫 관련 이슈

Resolves #207

✅ 구현 내용

  • 소셜 로그인을 통해 회원가입이 진행되는 경우, 닉네임과 이메일 중복 검사를 하도록 변경
  • 닉네임 또는 이메일이 중복되는 경우 해당 값을 null로 설정

@uijin-j uijin-j added the 🚨 돌 굴러가유 긴급 리뷰 label Mar 20, 2024
@uijin-j uijin-j added this to the 3차 스프린트 milestone Mar 20, 2024
@uijin-j uijin-j self-assigned this Mar 20, 2024
Sehee-Lee-01
Sehee-Lee-01 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 꼼꼼한 기능이 되었군요!!👍고생많으셨습니다!!

@github-actions GitHub Actions
Copy link

📝 Jacoco Test Coverage

Overall Project 67.81% -0.64% ❌
Files changed 18.33% ❌

File Coverage
UserInfoMapperFactory.java 73.91% 🍏
GithubUserInfoMapper.java 0% -62.82% ❌

@uijin-j uijin-j merged commit 7abca59 into dev Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sehee-Lee-01 Sehee-Lee-01 Sehee-Lee-01 approved these changes

@yenzip yenzip Awaiting requested review from yenzip yenzip is a code owner

Assignees

@uijin-j uijin-j

Labels
🚨 돌 굴러가유 긴급 리뷰
Projects
None yet
Milestone
3차 스프린트
Development

Successfully merging this pull request may close these issues.
2 participants
@uijin-j @Sehee-Lee-01