Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#246 fix GitHub login #247

Merged
merged 9 commits into from
Apr 14, 2024
Merged

Fix/#246 fix GitHub login #247

merged 9 commits into from
Apr 14, 2024

Conversation

uijin-j
Copy link
Contributor

@uijin-j uijin-j commented Apr 14, 2024

๐ŸŽซ ๊ด€๋ จ ์ด์Šˆ

Fixes #246

โœ… ๊ตฌํ˜„ ๋‚ด์šฉ

  • Spring Security OAuth2 ํ”„๋ ˆ์ž„์›Œํฌ ์‚ฌ์šฉ ๋Œ€์‹  ์†Œ์…œ ๋กœ๊ทธ์ธ ์ง์ ‘ ๊ตฌํ˜„

@uijin-j
chore: HTTP ์š”์ฒญ์„ ์œ„ํ•ด Webflux ์˜์กด์„ฑ ์ถ”๊ฐ€
da26634 
Webflux์—์„œ ์™ธ๋ถ€ ์„œ๋น„์Šค(๊นƒํ—ˆ๋ธŒ ์„œ๋ฒ„)์™€์˜ ํ†ต์‹ ์„ ์œ„ํ•œ WebCleint ์ œ๊ณต
@uijin-j
chore: Redis ์ปจํ…Œ์ด๋„ˆ๊ฐ€ ๊ณ„์† ์žฌ์‹œ์ž‘ ๋˜๋Š” ๋ช…๋ น์–ด ์‚ญ์ œ
9d3cd44
@uijin-j
chore: pull sidepeek_backend_secret
3ed654c
@uijin-j
feat: spring security oauth2 client๋ฅผ ์ด์šฉํ•œ oauth ๋กœ๊ทธ์ธ ๋ฐฉ์‹ ์ œ๊ฑฐ
bad7a21
@uijin-j
chore: Spring Security OAuth2 Client ์˜์กด์„ฑ ์ œ๊ฑฐ
8c3f688
@uijin-j
chore: ์†Œ์…œ ๋กœ๊ทธ์ธ API ์—”๋“œํฌ์ธํŠธ ์ถ”๊ฐ€
10438b9
@uijin-j
refactor: UserInfoMapper๊ฐ€ UserService์— ์˜์กดํ•˜์ง€ ์•Š๋„๋ก ๋ณ€๊ฒฝ
4537a5b
@uijin-j
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ์— ๋Œ€ํ•œ ์ฑ…์ž„์„ ๊ฐ–๋Š” OAuth2Manager ์ƒ์„ฑ
3cb9f2d 
๊นƒํ—ˆ๋ธŒ์™€ HTTP ํ†ต์‹ ์„ ๋‹ด๋‹นํ•˜๋Š” GithubOAuth2Manager ๊ตฌํ˜„
@uijin-j
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ(๊นƒํ—ˆ๋ธŒ) ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง ๊ตฌํ˜„
d883b5d
@uijin-j uijin-j self-assigned this Apr 14, 2024
@github-actions GitHub Actions
Copy link

๐Ÿ“ Jacoco Test Coverage

Overall Project 66.4% -3.43% โŒ
Files changed 16.62% โŒ

File Coverage
GithubOAuth2Properties.java 100% ๐Ÿ
SecurityConfig.java 100% ๐Ÿ
OAuth2ManagerFactory.java 73.91% -26.09% โŒ
UserInfoMapperFactory.java 72.73% ๐Ÿ
AuthService.java 51.07% -46.78% โŒ
GithubOAuth2Manager.java 10.19% -89.81% โŒ
GithubUserInfoMapper.java 4.35% -8.7% โŒ
AuthController.java 0% -27.27% โŒ

@uijin-j uijin-j merged commit 626384e into dev Apr 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenzip yenzip Awaiting requested review from yenzip yenzip is a code owner

@Sehee-Lee-01 Sehee-Lee-01 Awaiting requested review from Sehee-Lee-01 Sehee-Lee-01 is a code owner

Assignees

@uijin-j uijin-j

Labels
๐Ÿ› ์•„์ด๊ณ  ๋ฒŒ๋ ˆ! ๋ฒ„๊ทธ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uijin-j