회원가입 서비스 테스트 코드 작성 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenzip
approved these changes
Feb 14, 2024
| @@ -161,6 +161,8 @@ | |||
| <module name="TypeName"> | |||
| <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, | |||
| ANNOTATION_DEF, RECORD_DEF"/> | |||
| <!-- 클래스명 한글 허용 -->s | |||
| <property name="format" value="^[a-zA-Z_$\p{IsHangul}][a-zA-Z\d_$\p{IsHangul}]*$"/> | |||
There was a problem hiding this comment.
테스트 이름에 한글 적용하는 거 저는 정말 좋습니다..! (사심 x 100 🔥 )
|
|
||
| private User createUser(String email, String password, String nickname) { | ||
| return User.builder() | ||
| .email(isBlank(email) ? this.email : email) |
| .withMessage("이미 사용 중인 닉네임입니다."); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
개인적인 생각으로는 이메일이나 비밀번호 형식 관련 테스트는 @ParameterizedTest 로 다양한 형식을 테스트 해보는게 좋다고 생각하는데, 의진님은 어떻게 생각하시나요?
물론 기능 구현이 저희의 최우선의 목표이기 때문에 추후, 리팩토링데이에 적용해주셔도 될 것 같습니다 👍
There was a problem hiding this comment.
실패 테스트 경우는 ParameterizedTest 적용하는 것도 좋겠네요! 저도 우선 지금 코드도 너무 잘 짜주셔서 리팩토링 데이 때 해주셔도 될 것 같습니다!!
There was a problem hiding this comment.
넹! 저도 넘넘 좋습니다🥰 일단 내일이 스프린트 마감이니..
리팩토링 Task 백로그 페이지를 만들어 넣어 놓겠습니당!
Sehee-Lee-01
approved these changes
Feb 15, 2024
| @@ -161,6 +161,8 @@ | |||
| <module name="TypeName"> | |||
| <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, | |||
| ANNOTATION_DEF, RECORD_DEF"/> | |||
| <!-- 클래스명 한글 허용 -->s | |||
| <property name="format" value="^[a-zA-Z_$\p{IsHangul}][a-zA-Z\d_$\p{IsHangul}]*$"/> | |||
|
|
||
| @SpringBootTest | ||
| @Transactional | ||
| @DisplayNameGeneration(ReplaceUnderscores.class) |
| .withMessage("이미 사용 중인 닉네임입니다."); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
실패 테스트 경우는 ParameterizedTest 적용하는 것도 좋겠네요! 저도 우선 지금 코드도 너무 잘 짜주셔서 리팩토링 데이 때 해주셔도 될 것 같습니다!!
|
|
||
| private User createUser(String email, String password, String nickname) { | ||
| return User.builder() | ||
| .email(isBlank(email) ? this.email : email) |
| // then | ||
| User actual = userRepository.findById(saved).get(); | ||
| Password encodedPassword = actual.getPassword(); | ||
| assertThat(actual).extracting("email", "nickname", "provider") |
| SignUpRequest request = new SignUpRequest(newEmail, password, duplicatedNickname); | ||
|
|
||
| // when | ||
| ThrowingCallable signup = () -> userService.signUp(request, Provider.BASIC); |
📝 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #42
✅ 구현 내용