-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
기술 스택 및 회원 닉네임 검색 api 리팩토링 및 테스트 #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 18, 2024
Closed
Closed
📝 Jacoco Test Coverage
|
uijin-j
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 고생하셨습니당!
yenzip
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주말에 너무 고생 많으셨습니다 ❤️🔥
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java
Outdated
Show resolved
Hide resolved
src/test/java/sixgaezzang/sidepeek/skill/serivce/SkillServiceTest.java
Outdated
Show resolved
Hide resolved
📝 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #51
✅ 구현 내용
💬 코멘트
기술 스택 및 회원 닉네임 검색 api 관련해서 마무리로 테스트 코드 작성 및 리팩토링 진행했습니다!
코드,,양이 좀 많아지긴 했네요ㅠㅠㅠ 죄송합니다ㅠㅠ🥲