Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

기술 스택 및 회원 닉네임 검색 api 리팩토링 및 테스트 #52

Merged
merged 12 commits into from
Feb 19, 2024

Conversation

Sehee-Lee-01
Copy link
Member

🎫 관련 이슈

Resolves #51

✅ 구현 내용

  • 기술 스택 검색 테스트 코드 작성
  • 기술 스택 검색 Swagger 정리
  • 기술 스택 검색 예외처리 핸들링
  • 회원 닉네임 검색 테스트 코드 작성
  • 회원 닉네임 검색 Swagger 정리
  • 회원 닉네임 검색 예외 처리 핸들링

💬 코멘트

  • 기술 스택 및 회원 닉네임 검색 api 관련해서 마무리로 테스트 코드 작성 및 리팩토링 진행했습니다!

    • 테스트 코드 작성
    • Swagger 정리하기
    • 예외 처리 핸들링
  • 코드,,양이 좀 많아지긴 했네요ㅠㅠㅠ 죄송합니다ㅠㅠ🥲

Copy link

📝 Jacoco Test Coverage

Overall Project 68.23%
Files changed 100% 🍏

File Coverage
SkillService.java 100% 🍏
SignUpRequest.java 100% 🍏
SkillResponse.java 100% 🍏
SkillSearchResponse.java 100% 🍏
Skill.java 100% 🍏
UserSummaryResponse.java 100% 🍏
UserSearchResponse.java 100% 🍏
User.java 100% 🍏
UserService.java 100% 🍏
UserController.java 0% 🍏
SkillController.java 0% 🍏

Copy link
Contributor

@uijin-j uijin-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니당!

Copy link
Contributor

@yenzip yenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주말에 너무 고생 많으셨습니다 ❤️‍🔥

Copy link

📝 Jacoco Test Coverage

Overall Project 68.98%
Files changed 100% 🍏

File Coverage
SkillService.java 100% 🍏
SignUpRequest.java 100% 🍏
SkillResponse.java 100% 🍏
SkillSearchResponse.java 100% 🍏
Skill.java 100% 🍏
UserSummaryResponse.java 100% 🍏
UserSearchResponse.java 100% 🍏
User.java 100% 🍏
UserService.java 100% 🍏
UserController.java 0% 🍏
SkillController.java 0% 🍏

@Sehee-Lee-01 Sehee-Lee-01 merged commit 60b73c5 into dev Feb 19, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the refactor/#51-refactor-search-api branch February 19, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ 테스트혀봤슈 빌드&테스트가 필요할 때 태그 🌳 밥 좀 드셔유 천천히 리뷰 🛠 리팩토링했슈 리팩토링
Projects
None yet
3 participants