이메일 중복 확인 기능 구현 #53
Merged
이메일 중복 확인 기능 구현 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
yenzip
approved these changes
Feb 18, 2024
Sehee-Lee-01
approved these changes
Feb 19, 2024
| @@ -24,7 +24,7 @@ public SkillSearchResponse searchByName(String keyword) { | |||
| } | |||
|
|
|||
| validateMaxLength(keyword, KEYWORD_MAX_LENGTH, | |||
| "최대 " + KEYWORD_MAX_LENGTH + "자의 키워드로 검색할 수 있습니다."); | |||
| "최대 " + KEYWORD_MAX_LENGTH + "자의 키워드로 검색할 수 있습니다."); | |||
There was a problem hiding this comment.
요 부분은 제가 MAX_SKILL_NAME_LENGTH라는 상수 만들어서 적용했는데 머지하고 나서 제가 확인해볼게유! 코드 탭 정돈까지 해주셔서 감사합니당!!🥰
There was a problem hiding this comment.
충돌해결하면서 세희님 코드로 변경했습니다! 감사합니당!!🥰
| import sixgaezzang.sidepeek.users.service.UserService; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/users") | ||
| @Tag(name = "User", description = "User API") | ||
| @RequiredArgsConstructor | ||
| @Slf4j |
There was a problem hiding this comment.
혹시 요 클래스에서 로그 사용하는 코드가 있을까요! 제가 확인했을 땐 보이지가 않아서 여쭤봅니당!
There was a problem hiding this comment.
제가 디버그하려고 넣어놨다가 삭제하는 것을 까먹었네용!
감사합니다:)
Closed
2 tasks
📝 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #50
✅ 구현 내용
💬 코멘트