닉네임 중복 검사 기능 구현 #55
Merged
닉네임 중복 검사 기능 구현 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Jacoco Test Coverage
|
yenzip
approved these changes
Feb 18, 2024
Comment on lines
+209
to
+210
| String longNickname = faker.lorem() | ||
| .characters(User.MAX_NICKNAME_LENGTH + 1); |
Sehee-Lee-01
approved these changes
Feb 19, 2024
Comment on lines
6
to
9
| public record CheckNicknameRequest( | ||
| @NotBlank(message = "닉네임을 입력해주세요.") | ||
| @Size(max = 20, message = "닉네임은 20자 이하여야 합니다.") | ||
| String nickname |
There was a problem hiding this comment.
저 "20자"도 MAX_NICKNAME_LENGTH 적용해주면 좋을 것 같습니다!
| @@ -14,7 +14,7 @@ public record SignUpRequest( | |||
| @Pattern(regexp = Password.PASSWORD_REGXP, message = "비밀번호는 8자 이상이며 영문, 숫자, 특수문자를 포함해야 합니다.") | |||
| String password, | |||
| @NotBlank(message = "닉네임을 입력해주세요.") | |||
| @Length(max = 20, message = "닉네임은 20자 이하여야 합니다.") | |||
| @Size(max = 20, message = "닉네임은 20자 이하여야 합니다.") | |||
There was a problem hiding this comment.
요기도 MAX_NICKNAME_LENGTH 설정해주면 좋을 것 같습니당!
Closed
2 tasks
📝 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Resolves #54
✅ 구현 내용
💬 코멘트
feat/#50-check-email-duplicate브랜치에서 새로운 브랜치 따서 작업 했습니다!feat/#50-check-email-duplicate가dev에 머지되면feat/#54-check-nickname-duplicate도 dev로 머지하겠습니당!