-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
자동 로그인(리프레시 토큰) 기능 구현 #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sehee-Lee-01
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어려운 로직 짜느라 고생 너무 많으셨습니다....👍
전반적으로 메서드 나눠주신 흔적, autoconfiguration을 고려해서 클래스 필드를 정리해주신 점이 많이 보였습니다! 잘 나눠주셔서 잘 확인할 수 있었어요! 감삼당!!🥰`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
Fixes #12
✅ 구현 내용
💬 코멘트
1️⃣ Refresh Token의 접근이 빈번함 (빠른 in-memery 스토리지인 Redis가 적합)
2️⃣ DB에 영구적으로 보관되는 데이터가 아님
등의 이유로 Redis에 저장하기로 결정했습니다!
docker-compose.yml
파일을 수정했기 때문에.env
파일에도 환경 변수 설정이 필요합니다! (구두로 전달드리겠습니당!)🙏🏻 sidepeek_backend_secret에 Redis 관련 속성을 추가해서 pull 한번만 부탁 드립니다!