Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회원 프로필 조회/수정 및 비밀번호 수정 api 스웨거 설정 #87

Merged
merged 15 commits into from
Mar 5, 2024
Merged

회원 프로필 조회/수정 및 비밀번호 수정 api 스웨거 설정 #87

merged 15 commits into from
Mar 5, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Mar 3, 2024 •
edited
Loading

🎫 관련 이슈

Resolves #85

✅ 구현 내용

  • 회원 프로필 조회 api 스웨거 설정
  • 회원 프로필 수정 api 스웨거 설정
  • 회원 비밀번호 수정 api 스웨거 설정

💬 코멘트

  • 기능 구현은 안하고 스웨거 설정을 위해서 dto, 컨트롤러만 작성했습니다!
  • 공통적인 메시지나 값은 상수처리해서 따로 상수 클래스, 메시지 클래스에다가 옮겨놓았습니다!

@Sehee-Lee-01 Sehee-Lee-01 added this to the 3차 스프린트 milestone Mar 3, 2024
@Sehee-Lee-01 Sehee-Lee-01 self-assigned this Mar 3, 2024
@Sehee-Lee-01 Sehee-Lee-01 linked an issue Mar 3, 2024 that may be closed by this pull request
회원 세부 정보 관련 api 컨트롤러 구현 #85
Closed
3 tasks
uijin-j
uijin-j reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@uijin-j uijin-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것저것 신경쓸게 많으셨을텐데, 먼저 컨트롤러 작성 해주셔서 감사합니다..🥹🥹💗

src/main/java/sixgaezzang/sidepeek/projects/domain/member/Member.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/common/exception/message/CommonErrorMessage.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/dto/request/UpdatePasswordRequest.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/dto/request/UserProfileRequest.java Outdated Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/dto/request/UserSkillRequest.java Outdated Show resolved Hide resolved
yenzip
yenzip reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@yenzip yenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다..! ❤️‍🔥

src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
src/main/java/sixgaezzang/sidepeek/users/controller/UserController.java Show resolved Hide resolved
yenzip
yenzip approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@yenzip yenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 Approve 한다는 것을 까먹었네요..!

Base automatically changed from feat/#80-project-comment-controller to dev March 5, 2024 05:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

📝 Jacoco Test Coverage

Overall Project 68.24% -2.72% ❌
Files changed 7.76% ❌

File Coverage
MemberSaveRequest.java 100% 🍏
ProjectRequest.java 100% 🍏
SignUpRequest.java 100% 🍏
User.java 100% 🍏
Member.java 100% 🍏
UserService.java 100% 🍏
UserErrorCode.java 96.43% 🍏
ProjectValidator.java 91.59% 🍏
MemberValidator.java 90.91% 🍏
UserController.java 0% -25.45% ❌
MemberErrorMessage.java 0% 🍏
ProjectErrorMessage.java 0% 🍏
CommonErrorMessage.java 0% ❌
UpdatePasswordRequest.java 0% ❌
UpdateUserProfileRequest.java 0% ❌
CheckNicknameRequest.java 0% 🍏
UpdateUserSkillRequest.java 0% ❌
UserSkillSummary.java 0% ❌
UserProfileResponse.java 0% ❌
UserConstant.java 0% ❌
UserErrorMessage.java 0% ❌

@Sehee-Lee-01 Sehee-Lee-01 merged commit 1b50f5c into dev Mar 5, 2024
2 checks passed
@Sehee-Lee-01 Sehee-Lee-01 deleted the feat/#85-user-profile-swagger branch March 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uijin-j uijin-j uijin-j left review comments

@yenzip yenzip yenzip approved these changes

Assignees

@Sehee-Lee-01 Sehee-Lee-01

Labels
🚀 더 만들어봤슈 기능 구현
Projects
None yet
Milestone
3차 스프린트
Development

Successfully merging this pull request may close these issues.

회원 세부 정보 관련 api 컨트롤러 구현
3 participants
@Sehee-Lee-01 @uijin-j @yenzip