Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/#5/ProjectCard] 프로젝트 카드 컴포넌트 #21

Merged
merged 6 commits into from
Feb 15, 2024
Merged

[feature/#5/ProjectCard] 프로젝트 카드 컴포넌트 #21

merged 6 commits into from
Feb 15, 2024

Conversation

miloul
Copy link
Contributor

@miloul miloul commented Feb 15, 2024 •
edited
Loading

#️⃣연관된 이슈

#11

💡 핵심적으로 구현된 사항

프로젝트 카드 컴포넌트
프로젝트 드

➕ 그 외에 추가적으로 구현된 사항

없음

@miloul miloul added Design 디자인 Feat 기능 구현 labels Feb 15, 2024
@miloul miloul added this to the 1차 스프린트 milestone Feb 15, 2024
@miloul miloul self-assigned this Feb 15, 2024
whdgur5717
whdgur5717 reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@whdgur5717 whdgur5717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
저는 개인적으로 Layout을 담당하는 부분과 내용 부분을 컴포넌트를 분리하는 게 좋을 것 같다는 생각이 듭니다(아니면 합성컴포넌트도 괜찮을 것 같습니다)

src/components/ProjectCard/ProjectCard.tsx Outdated Show resolved Hide resolved
src/components/ProjectCard/ProjectCard.tsx Outdated Show resolved Hide resolved
wdgWon
wdgWon approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@wdgWon wdgWon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!
저는 컨벤션이나 스타일에서 딱히 피드백할게 안보였습니다!
근데 확실히 스타일 때문에 전체 코드가 길어지는 부분이 마음에 걸리네요...
일단 카드 컴포넌트 수고하셨습니다! 👍

Whoknow77
Whoknow77 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Whoknow77 Whoknow77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@miloul miloul merged commit e393d67 into dev Feb 15, 2024
@miloul miloul deleted the feature/#5/ProjectCard branch February 20, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whdgur5717 whdgur5717 whdgur5717 left review comments

@wdgWon wdgWon wdgWon approved these changes

@Whoknow77 Whoknow77 Whoknow77 approved these changes

Assignees

@miloul miloul

Labels
Design 디자인 Feat 기능 구현
Projects
None yet
Milestone
1차 스프린트
Development

Successfully merging this pull request may close these issues.
4 participants
@miloul @Whoknow77 @whdgur5717 @wdgWon