Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

알람 버튼 클릭시 버블링을 막고 알럿이 뜨도록 한다 #132

Merged
merged 6 commits into from
Nov 19, 2021

Conversation

dididy
Copy link
Member

@dididy dididy commented Nov 19, 2021

Summary

알람 버튼 클릭시 버블링을 막고 알럿이 뜨도록 한다

Detail

  • e.stopPropagation() 으로 이벤트 전파 막음
  • 댓글 알람 삭제시 알럿 뜨도록 함

Issue

연관된 이슈 #66

@dididy dididy added the fix label Nov 19, 2021
@dididy dididy requested a review from seung-00 November 19, 2021 13:11
@dididy dididy self-assigned this Nov 19, 2021
@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for optimistic-hawking-c622d6 ready!

🔨 Explore the source changes: 43cf30f

🔍 Inspect the deploy log: https://app.netlify.com/sites/optimistic-hawking-c622d6/deploys/6197ead2172e440007eeb6c5

😎 Browse the preview: https://deploy-preview-132--optimistic-hawking-c622d6.netlify.app

Landing 페이지를 삭제하고 side로 리다이렉트 되도록 처리한다
@dididy dididy merged commit 0cc8cdb into develop Nov 19, 2021
@dididy dididy deleted the fix/qa-s branch November 19, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants