feat: implement CLI commands for user management #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unix4ever
force-pushed
the
implement-user-cli-service-account-ui
branch
6 times, most recently
from
9678b6f to
f1426e7
Compare
smira
reviewed
Dec 10, 2024
| return err | ||
| } | ||
|
|
||
| _, err = safe.StateUpdateWithConflicts(ctx, client.Omni().State(), |
There was a problem hiding this comment.
the commands seem to be untested (?)
even adding a simple integration test to create/delete/update a user would ensure the commands are not broken in the future
There was a problem hiding this comment.
good idea. Added the CLI tests for it.
Unix4ever
force-pushed
the
implement-user-cli-service-account-ui
branch
from
f1426e7 to
b1ab823
Compare
Add the UI for showing and editing service accounts. Fixes: siderolabs#197 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
implement-user-cli-service-account-ui
branch
from
b1ab823 to
a7b603e
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the UI for showing and editing service accounts.
Added CLI commands:
Fixes: #197