fix: properly handle upgrades for the machines with invalid schematics #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple fix to not skip updating Talos if the machine schematic is empty. Signed-off-by: Artem Chernyshev <[email protected]>
smira
reviewed
Mar 18, 2024
| @@ -129,7 +129,7 @@ func NewClusterMachineConfigStatusController() *ClusterMachineConfigStatusContro | |||
| machineStatus.TypedSpec().Value.Schematic.Id != expectedSchematic | |||
|
|
|||
| // don't run the upgrade check if the running version and expected versions match | |||
| if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" && talosVersion.TypedSpec().Value.SchematicId != "" { | |||
| if versionMismatch && talosVersion.TypedSpec().Value.TalosVersion != "" { | |||
There was a problem hiding this comment.
how does it work with "invalid" schematics? is it going to wipe it?
There was a problem hiding this comment.
No, it's going to keep using the vanilla installer.
This code is in place, but this check made it skip the upgrade function as a whole.
smira
approved these changes
Mar 18, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to not skip updating Talos if the machine schematic is empty.
Verified that on a cluster running on the nodes with the invalid schematics. Upgrades work.