Use same credentials for MAC based protection at Downstream #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiron-mx
force-pushed
the
91-response-protection-not-correctly-chosen
branch
from
1dc863e
to
d5df3f1
Compare
|
Akretsch
reviewed
May 2, 2024
src/main/java/com/siemens/pki/cmpracomponent/msgprocessing/RaDownstream.java
Outdated
Show resolved
Hide resolved
| import org.bouncycastle.asn1.pkcs.PBKDF2Params; | ||
| import org.bouncycastle.asn1.pkcs.PKCSObjectIdentifiers; | ||
|
|
||
| public class SharedSecretCredentials implements SharedSecretCredentialContext { |
There was a problem hiding this comment.
rename to RespondingSharedSecretCredentials or similar
src/test/java/com/siemens/pki/cmpracomponent/test/Pbmac1EnrollmentTestcasebase.java
Outdated
Show resolved
Hide resolved
src/test/java/com/siemens/pki/cmpracomponent/test/TestMacProtectedIp.java
Outdated
Show resolved
Hide resolved
src/test/java/com/siemens/pki/cmpracomponent/test/TestPbmac1Ir.java
Outdated
Show resolved
Hide resolved
kiron-mx
force-pushed
the
91-response-protection-not-correctly-chosen
branch
from
d5df3f1
to
1dc863e
Compare
…sages at RaDownstream
kiron-mx
force-pushed
the
91-response-protection-not-correctly-chosen
branch
from
1dc863e
to
b2090d9
Compare
Akretsch
approved these changes
Sep 10, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #91
MessageContextto store persistency context and verification credentials of incoming messages