Merge our current version of the code with the OSS libsecutils. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DDvO @benjamin-schilling could you, please, review this and then merge it? If you have any comments, or you find any issues, let me know. Thanks |
martin-barta-sie
changed the title
(reflects securityUtilities b009f9d5)
API changes:
- functions for checking only against local CRLs added
- more generic functions for calculating/checking ICV added
- some functions moved to appropriate module (to util.h)
Internal changes:
- loading of credentials (.p12 containers):
- containers with **empty password** are **rejected** if a nonempty
password is provided as parameter (i.e. the empty password can no longer
be used to circumvent UTA-protection)
- containers that don't have private keys encrypted with the same algorithm
that is used by "storage" functions (e.g. `CREDENTIALS_save_dv`) are
**rejected**
- default log level changed to `LOG_WARNING` (should have minimal impact as
most logs state the level explicitly)
Other changes:
- some includes fixed
- various compiler warnings fixed
martin-barta-sie
force-pushed
the
feature/s2l2-sync
branch
from
a6278c3
to
1a6f340
Compare
|
The changelog sounds good, but it is quite a lot of stuff at once, mixed into a monolithic commit and PR. |
|
OK, I will try to split it into smaller ones |
|
@DDvO I've split it up into the following pull requests. Sorry it took so long, but I wanted to wait until we ironed out all the issues we found when integrating this in our projects. I will close this request as it's not needed anymore.
Less important: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our attempt to once and for all unify our fork with the OSS code base. From this release onward, any potential future changes/updates will be directly contributed here.
Overview of Changes
API changes:
Internal changes:
password is provided as parameter (i.e. the empty password can no longer
be used to circumvent UTA-protection)
that is used by "storage" functions (e.g.
CREDENTIALS_save_dv) arerejected
LOG_WARNING(should have minimal impact asmost logs state the level explicitly)
Other changes: